potiuk opened a new pull request, #45131:
URL: https://github.com/apache/airflow/pull/45131
When providers system tests were modified in provider tests were modified,
selective checks had two bugs that compounded led to provider tests being
skipped.
1) Modification of system tests lead to "all providers affected"
condition (wrongly) - because "TESTS" were checked as root path
before "SYSTEM TESTS" - and since system tests were subfolder
of tests, the code that checked if system tests path belongs
to provider never found it.
2) "All Providers affected" in such case (when it was not caused by
another condition lead to "skip-provider-tests" set to true due
to missing "else" in one of the conditions.
This PR fixes both cases and simplifies the conditions so that they are
easier to understand and modify. Those conditions will be further simplified
when we separate providers to separate projects #44511 because there we will
not have to check separately several sub-folders of airflow, but for now it's
good enough.
Some of those conditions are simplified as well because we are in Python
3.9+ and "is_relative_to" is now available in Path.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
