potiuk commented on code in PR #45162:
URL: https://github.com/apache/airflow/pull/45162#discussion_r1895053319


##########
.github/workflows/ci.yml:
##########
@@ -21,9 +21,15 @@ on:  # yamllint disable-line rule:truthy
   schedule:
     - cron: '28 1,7,13,19 * * *'
   push:
-    branches: ['v[0-9]+-[0-9]+-test', 'providers-*/v[0-9]+-[0-9]+]']
+    branches:

Review Comment:
   Well. Just to have some interesting discussion on specs:
   
   > Mhm, but reading the YAML specs in 
https://yaml.org/spec/1.2.2/#plain-style I think @shubhamraj-git is right. If 
the literals [ and ] arecontained then it is advised to quote it:
   
   > In addition, inside [flow 
collections](https://yaml.org/spec/1.2.2/#flow-collection-styles), or when used 
as [implicit 
keys](https://yaml.org/spec/1.2.2/#example-single-pair-explicit-entry), plain 
scalars must not contain the “[”, “]”, “{”, “}” and “,” characters.
   
   * Yeah. "flow collections" was what it was before (and it was quoted) - but 
I just changed it to `block collections' :)
   * Implicit keys - are different things.
   
   So we are safe :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to