potiuk commented on code in PR #45191:
URL: https://github.com/apache/airflow/pull/45191#discussion_r1896518231
##########
tests/api_fastapi/core_api/routes/ui/test_structure.py:
##########
@@ -404,7 +405,7 @@ class TestStructureDataEndpoint:
def test_should_return_200(self, test_client, params, expected):
response = test_client.get("/ui/structure/structure_data",
params=params)
assert response.status_code == 200
- assert response.json() == expected
+ assert not DeepDiff(response.json(), expected, ignore_order=True)
Review Comment:
Nice small tool.
BTW. @gopidesupavan -> maybe we could use `deephash` from the same set of
tools to make stable hashes of config dictionaries?
There is one thing that is "specific" to how config help is extracted
(Python 3.12 performs slightly different dedenting of docstrings extracted from
methods) - but I think `deephash` should nicely handle the last change with
opts sorting and possibly other in-stabilities that `click` might introduce -
see https://github.com/apache/airflow/pull/45156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
