jscheffl commented on code in PR #45238:
URL: https://github.com/apache/airflow/pull/45238#discussion_r1898737796
##########
airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -58,7 +58,7 @@ const columns: Array<ColumnDef<VariableResponse>> = [
cell: ({ row: { original } }) => (
<Flex justifyContent="end">
<EditVariableButton editKey={original.key} />
- <DeleteVariableButton deleteKey={original.key} />
+ <DeleteVariableModal deleteKey={original.key} />
Review Comment:
Is it not a bit mis-leading that you now call it "Modal" whereas the modal
just comes after the button? Should we not name it "Button" as before and the
button brings a modal for confirmation with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
