amoghrajesh commented on code in PR #45310:
URL: https://github.com/apache/airflow/pull/45310#discussion_r1900191350


##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -423,13 +441,14 @@ def run(ti: RuntimeTaskInstance, log: Logger):
             state=TerminalTIState.FAIL_WITHOUT_RETRY,
             end_date=datetime.now(tz=timezone.utc),
         )
-
         # TODO: Run task failure callbacks here
-    except AirflowTaskTimeout:
-        # TODO: handle the case of up_for_retry here
-        # TODO: coagulate this exception handling with AirflowException
-        # once https://github.com/apache/airflow/issues/45307 is handled
-        ...

Review Comment:
   Coagulating both these exceptions into a single handler, as they do the same 
thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to