amoghrajesh commented on code in PR #44841:
URL: https://github.com/apache/airflow/pull/44841#discussion_r1900316974
##########
chart/values.yaml:
##########
@@ -125,7 +125,8 @@ images:
pullPolicy: IfNotPresent
# Select certain nodes for airflow pods.
-nodeSelector: {}
+nodeSelector:
+ eks.amazonaws.com/nodegroup: production-applications-nodes
Review Comment:
Same here
##########
chart/values.yaml:
##########
@@ -134,10 +135,17 @@ schedulerName: ~
# Add common labels to all objects and pods defined in this chart.
labels: {}
+istio:
+ enabled: true
Review Comment:
Cannot have true by default.
##########
chart/values.yaml:
##########
@@ -1255,11 +1267,11 @@ webserver:
defaultUser:
enabled: true
role: Admin
- username: admin
- email: [email protected]
- firstName: admin
- lastName: user
- password: admin
+ username: [email protected]
+ email: [email protected]
+ firstName: madtechai
+ lastName: isocrates
+ password: <]81-ck1=J[£iDnP0£t-
Review Comment:
We cannot commit as per your credentials. Also please do not push passwords
##########
chart/values.yaml:
##########
@@ -79,10 +79,10 @@ airflowVersion: "2.8.1"
# Images
images:
airflow:
- repository: ~
- tag: ~
+ repository:
017820686756.dkr.ecr.us-east-1.amazonaws.com/production-isocrates-madtechai-airflow
+ tag: "airflow-2.0.0"
Review Comment:
We cannot hardcode per your deployment, please undo this
##########
chart/values.yaml:
##########
@@ -426,7 +434,7 @@ fernetKey: ~
fernetKeySecretName: ~
# Flask secret key for Airflow Webserver: `[webserver] secret_key` in
airflow.cfg
-webserverSecretKey: ~
+webserverSecretKey: "de21ceaf0169b10919a8160b2e507256"
Review Comment:
Please do not commit keys
##########
chart/values.yaml:
##########
@@ -134,10 +135,17 @@ schedulerName: ~
# Add common labels to all objects and pods defined in this chart.
labels: {}
+istio:
+ enabled: true
+ gateway:
+ name: 'istio-system/istio-gateway'
+ virtualService:
+ host: 'airflow.madtechai.com'
+
# Ingress configuration
ingress:
# Enable all ingress resources (deprecated - use ingress.web.enabled and
ingress.flower.enabled)
- enabled: ~
+ enabled: false
Review Comment:
Need to undo this too
##########
chart/values.yaml:
##########
@@ -134,10 +135,17 @@ schedulerName: ~
# Add common labels to all objects and pods defined in this chart.
labels: {}
+istio:
+ enabled: true
+ gateway:
+ name: 'istio-system/istio-gateway'
+ virtualService:
+ host: 'airflow.madtechai.com'
Review Comment:
Cannot have this one, has to be generic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]