potiuk commented on issue #44950: URL: https://github.com/apache/airflow/issues/44950#issuecomment-2567064113
DEfinitely if you add tests there and make it green and ping a bit more in the PR, there is a chance that now - after holidays there will be interest. Maybe @alexott might help there. But in general one of the first things to do - before any reviews is to add unit tests and show that you understand the problem, error case and that you are providing solution to it. It's much easier for anyone doing the review (especially if they do not know much about databricks - Airflow maintainers are NOT databricks specialists - we just integrate with it) if they see that you can show the test case that they will be able to understand, see it running and see it in a bigger context. You simply increase your chances of getting the review this way. Not mentioning that you submitted your change just before holidays and for many people holidays are still there and conssidering that most maintainers are pretty busy preparing to Airflow 3. Also this is the first test for any author of any PR. Are you self-sufficient and self-driven? Can you come to the right conclusions, follow the contribution docs, look at other PRs and learn from them that unit tests are a prerequisite for reviewers to spend their time on that - generally red PR with 2 line changes is an indication of heavily-work-in-progress that the author have not spend a lot of time on trying to understand the problem. solution, being able to reason about it and answer questions "why this test" (especially if there is no test). So I would encourage you to continue working on it. And no- there is never guarantee that PR will be merged. Sometimes after a discussion, showing test and mutual understanding between author and reviewers the discussion might lead to different solutions - and this is good, because everyone learns along the way - even if code that you wrote is thrown away and replaced by something else. You should treat such open PR as a learning opportunity, and by providing the reviewer more of an indication that you have not only spend a bit of time on providing fix but also understanding howt things work here and responding to the needs of reviewers who sometimes had to review 30 PRs a day and do it in their free time as well as you do contributions - you increse your chances on getting your change (or whatever will result of it) merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
