TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to 
Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#issuecomment-536537383
 
 
   @potiuk I've added message validation. Now when user pass message data as a 
string which can be base64 decoded, an additional deprecation warning will be 
displayed, afterwards`PubSub` exception will be raised. I've updated tests, 
added tests for message validation and added additional info in `UPDATING.md`.
   About deprecation warning for `template_fields` I think it is possible 
however in my opinion it will introduce unnecessary amount of complication. 
I've included Information about `template_filelds` in  `UPDATING.md` as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to