shubhamraj-git commented on code in PR #45270: URL: https://github.com/apache/airflow/pull/45270#discussion_r1901963147
########## airflow/ui/src/components/FlexibleForm/FlexibleFormFieldBool.tsx: ########## @@ -0,0 +1,31 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { FlexibleFormElementProps } from "."; +import { Switch } from "../ui"; + +export const isFieldBool = (fieldType: string) => fieldType === "boolean"; + +export const FlexibleFormFieldBool = ({ name, param }: FlexibleFormElementProps) => ( + <Switch + colorPalette="blue" + defaultChecked={param.value as boolean} Review Comment: Let's use `Boolean(param.value)` to avoid any runtime issues. ########## airflow/ui/src/components/FlexibleForm/FlexibleFormFieldDate.tsx: ########## @@ -0,0 +1,37 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Input } from "@chakra-ui/react"; + +import type { ParamSchema } from "src/queries/useDagParams"; + +import type { FlexibleFormElementProps } from "."; + +export const isFieldDate = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "string" && fieldSchema.format === "date"; + +export const FlexibleFormFieldDate = ({ name, param }: FlexibleFormElementProps) => ( + <Input + defaultValue={param.value as string} Review Comment: Should we check the type of param.value or it will be for sure string? If No, we should consider using `typeof param.value === "string" ? param.value : "";` ########## airflow/ui/src/components/FlexibleForm/FlexibleFormFieldAdvancedArray.tsx: ########## @@ -0,0 +1,56 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { json } from "@codemirror/lang-json"; +import { githubLight, githubDark } from "@uiw/codemirror-themes-all"; +import CodeMirror from "@uiw/react-codemirror"; + +import { useColorMode } from "src/context/colorMode"; +import type { ParamSchema } from "src/queries/useDagParams"; + +import type { FlexibleFormElementProps } from "."; + +export const isFieldAdvancedArray = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "array" && fieldSchema.items?.type !== "string"; + Review Comment: I see many utility func in each component. Can we have a separate file to have all that one ? Maybe `FlexibleFormUtility` , no hard suggestions. This will remove the warnings too.. ``` Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
