jscheffl commented on code in PR #45434:
URL: https://github.com/apache/airflow/pull/45434#discussion_r1904334242
##########
airflow/ui/src/components/ClearRun/ClearRunTaskAccordion.tsx:
##########
@@ -93,6 +101,34 @@ const ClearRunTasksAccordion = ({ affectedTasks }: Props)
=> (
</Box>
</Accordion.ItemContent>
</Accordion.Item>
+ <Accordion.Item key="note" value="note">
Review Comment:
Why do you render another accodion around the note? This means another click
is needed to see previous note and change it. I assume the field is small
enough (can hold <1000 chars anyway, not very long text...) - I would rather
propose to render it directly - w/o accordion. Then people are more easily
encouraged to leave a note - I think this feature is not used very much because
the entry was missing in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
