kaxil commented on code in PR #45509:
URL: https://github.com/apache/airflow/pull/45509#discussion_r1909353495
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -551,6 +551,40 @@ def execute(self, context):
)
[email protected](
+ "task_ids",
+ [
+ "push_task",
+ ["push_task1", "push_task2"],
+ {"push_task1", "push_task2"},
+ ],
+)
+def test_xcom_pull_behavior(create_runtime_ti, mock_supervisor_comms,
spy_agency, task_ids):
Review Comment:
The reason we had to change the test as it is right now is to actual tests
what is being sent.
The test earlier here, didn't validate what was being sent and instead just
checked `ti.xcom_pull` args. So it wouldn't have caught bugs
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -551,6 +551,40 @@ def execute(self, context):
)
[email protected](
+ "task_ids",
+ [
+ "push_task",
+ ["push_task1", "push_task2"],
+ {"push_task1", "push_task2"},
+ ],
+)
+def test_xcom_pull_behavior(create_runtime_ti, mock_supervisor_comms,
spy_agency, task_ids):
Review Comment:
The reason we had to change the test as it is right now is to actual tests
what is being sent.
The test earlier here, didn't validate what was being sent and instead just
checked `ti.xcom_pull` args. So it wouldn't have caught bugs including our
string case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
