ferruzzi commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1910853889
##########
airflow/metrics/base_stats_logger.py:
##########
@@ -31,55 +33,53 @@ class StatsLogger(Protocol):
instance: StatsLogger | NoStatsLogger | None = None
- @classmethod
def incr(
cls,
- stat: str,
+ metric_name: str,
Review Comment:
I've asked Arshia to revert that part of the change. I like the idea, the
name is way more clear, but we can deal with that discussion another time. I'd
like to get this merged as it is holding up a little project that he and Danny
are working on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
