RNHTTR commented on code in PR #45528:
URL: https://github.com/apache/airflow/pull/45528#discussion_r1911267036
##########
providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -147,10 +147,12 @@ def _run(
# For info about k8s timeout settings see
#
https://github.com/kubernetes-client/python/blob/v29.0.0/examples/watch/timeout-settings.md
# and
https://github.com/kubernetes-client/python/blob/v29.0.0/kubernetes/client/api_client.py#L336-L339
- client_timeout = 30
- server_conn_timeout = 3600
- kwargs["_request_timeout"] = client_timeout
- kwargs["timeout_seconds"] = server_conn_timeout
+ if "_request_timeout" not in kwargs:
+ client_timeout = 30
+ kwargs["_request_timeout"] = client_timeout
+ if "timeout_seconds" not in kwargs:
+ server_conn_timeout = 3600
+ kwargs["timeout_seconds"] = server_conn_timeout
Review Comment:
```suggestion
if "_request_timeout" not in kwargs:
kwargs["_request_timeout"] = 30
if "timeout_seconds" not in kwargs:
kwargs["timeout_seconds"] = 3600
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
