kaxil commented on code in PR #45578:
URL: https://github.com/apache/airflow/pull/45578#discussion_r1912083867
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -908,10 +922,7 @@ def supervise(
# If we are told to write logs to a file, redirect the task logger to
it.
from airflow.sdk.log import init_log_file, logging_processors
- try:
- log_file = init_log_file(log_path)
- except OSError as e:
- log.warning("OSError while changing ownership of the log file. ",
e)
Review Comment:
This was just redundant as `init_log_file` already capture and warns it:
https://github.com/apache/airflow/blob/6844cce95e1d02b06a2de7159db9eb2ea48ac74b/task_sdk/src/airflow/sdk/log.py#L427-L434
<img width="1061" alt="image"
src="https://github.com/user-attachments/assets/22abfe6e-6ef0-4faa-be4c-66399a30be9c";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
