jscheffl commented on PR #45530:
URL: https://github.com/apache/airflow/pull/45530#issuecomment-2585344164

   > Nice catch! One edge case that I thought about though* - what if the 
corresponding setup task hasn't finished running yet? (if such exists ofc) For 
example: 
![image](https://private-user-images.githubusercontent.com/60007259/401885485-e41019c0-1788-4f1e-9745-48e0ede7ad07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY1Mzk1OTEsIm5iZiI6MTczNjUzOTI5MSwicGF0aCI6Ii82MDAwNzI1OS80MDE4ODU0ODUtZTQxMDE5YzAtMTc4OC00ZjFlLTk3NDUtNDhlMGVkZTdhZDA3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAxMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTEwVDIwMDEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1MTQyOTFjNjQ5NmRhMDQ4NmZjMGJkYmI4N2Y4YmQyYjI3ZGI3NDY4N2I2NzliNTRjYjA2YWU3MmM4ZGQ4MWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uZ8ztTGGj75LBIpfubeTOCLsEZmUhLSXLYs7i6f4x7M)
 If you set the DAG run to `failed` before the c
 luster was created, the `delete_cluster` should be skipped.
   > 
   > * Maybe the current architecture already handles, but it's worth checking 
before merging this PR.
   
   Oh, yeah. Tested this explicitly. And actually the Scheduler had this 
feature before (added this to docs as well, was also new to me): If the setup 
task is skipped (which is the state when you mark as failed and it was not 
running) then the teardown is also skipped,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to