nrobinson-intelycare opened a new pull request, #45619:
URL: https://github.com/apache/airflow/pull/45619

   When using a deferrable BatchOperator, it is possible to specify the 
`max_retries` and `poll_interval`, but this does not appear to terminate the 
job once the task times out.
   
   Having the ability to specify the timeout and letting the job be terminated 
will allow us to enforce strict timeouts on critical pipelines running on 
Fargate via AWS Batch.
   
   This PR adds support to allow specifying `timeout` in the BatchOperator 
constructor:\
   
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/batch/client/submit_job.html
   
   > timeout (dict) –
   >
   > The timeout configuration for this SubmitJob operation. You can specify a 
timeout duration after which Batch terminates your jobs if they haven’t 
finished. If a job is terminated due to a timeout, it isn’t retried. The 
minimum value for the timeout is 60 seconds. This configuration overrides any 
timeout configuration specified in the job definition. For array jobs, child 
jobs have the same timeout configuration as the parent job. For more 
information, see [Job 
Timeouts](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/job_timeouts.html)
 in the Amazon Elastic Container Service Developer Guide.
   >
   > - attemptDurationSeconds (integer) –
   >
   >    The job timeout time (in seconds) that’s measured from the job 
attempt’s startedAt timestamp. After this time passes, Batch terminates your 
jobs if they aren’t finished. The minimum value for the timeout is 60 seconds.
   >
   >    For array jobs, the timeout applies to the child jobs, not to the 
parent array job.
   >
   >    For multi-node parallel (MNP) jobs, the timeout applies to the whole 
job, not to the individual nodes.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to