uranusjr commented on code in PR #45370:
URL: https://github.com/apache/airflow/pull/45370#discussion_r1916074001
##########
airflow/models/dag.py:
##########
@@ -1727,86 +1727,63 @@ def add_logger_if_needed(ti: TaskInstance):
@provide_session
def create_dagrun(
self,
- state: DagRunState,
*,
- triggered_by: DagRunTriggeredByType | None,
- logical_date: datetime | None = None,
- run_id: str | None = None,
- start_date: datetime | None = None,
- external_trigger: bool | None = False,
+ run_id: str,
+ logical_date: datetime,
+ data_interval: tuple[datetime, datetime],
Review Comment:
Maybe at some point. Many calls use the tuple format and I’m relectant to
make this PR even bigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
