IKholopov opened a new pull request, #45684:
URL: https://github.com/apache/airflow/pull/45684

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   This is a simple draft with PoC of AIP-85 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-85+Extendable+DAG+parsing+controls.
   
   The key highlights and proposed interfaces/implementations are:
   1) `airflow/dag_processing/dag_importer.py`: DagImporter - a mechanism 
abstracting a way of how a "path" is translated into one or more parsed DAGs. 
      - Default implementation is `FSDagImporter` 
(`airflow/dag_processing/fs_dag_importer.py`) - read a DAG from definition in a 
Python file. 
      - Alternative "demo" implementation - `NotebooksImporter` 
(`providers/src/airflow/providers/google/common/importers/notebooks_importer.py`),
 which imports Python definitions from Jupyter notebook files (for 
demonstration purposes only, not part of the actual AIP).
   
   2) `airflow/dag_processing/dag_ingester.py`: DagIngester - a mechanism to 
abstract away the logic of operations of parsing/adding/updating/removing DAGs 
and their importing metadata (i.e. importing errors/warnings). Sample 
implementations:
      - Continuous ingester (`airflow/dag_processing/continuous_ingester.py`) - 
replication of the current regular dag-processor paring logic (by reusing 
current DagFileProcessingManagers)
      - Once ingester (`airflow/dag_processing/once_ingester.py`) - ingester 
that only imports DAGs once
   
   Those 2 interfaces (that are allowed to be extended by providers/core 
Airflow) build a foundation to address AIP-85 requirements - increase 
flexibility of how DAGs are being updated and how they can be defined.
   
   Apart from that, DagBag usage is replaced in most places with one of the 
following components:
     - DagStore (`airflow/dag_processing/dag_store.py`) - access to Airflow 
DAGs in metadata DBs (no access to DAG sources required). Used by any component 
that requires access to DAG's metadata (i.e. by scheduler, public API, etc.).
     - DagParser (`airflow/dag_processing/dag_parser.py`) - access to parsed 
DAGs (used by worker and dag-processor).
   
   A lot of things are "swept under the rug" here as this is just a PoC based 
on an older Airflow branch before most of Airflow 3 changes landed. Big things 
that are missing:
     - Callbacks are not yet moved to a separate component (temporarily 
disabled)
     - Integration with bundles
     - Missing optimizations around module importing
     - DagCode is not propagated for non-FSDagImporter
   
   
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to