dabla commented on PR #45640: URL: https://github.com/apache/airflow/pull/45640#issuecomment-2593334047
> > @eladkal Would it hurt if some methods in Dialects are being renamed? I don't think it's actually used yet by any released provider right? > > I'm thinking of renaming following 2 methods: > > escape_colmun_name -> escape_word remove_quotes -> unescape_word > > Dialects were not yet released so you can introduce changes. Once I cut a release you won't be able to introduce breaking changes without doing a major release Ok if approved this one can we merged, I tested it locally and works as expected. Yesterday we encountered a new DAG which had to persist records to a table which name was a reserved word and had also column names as reserved words in MS SQL, the perfect test case 🤣 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
