ashb commented on code in PR #45562:
URL: https://github.com/apache/airflow/pull/45562#discussion_r1917136175
##########
airflow/triggers/base.py:
##########
@@ -124,6 +124,11 @@ def __repr__(self) -> str:
classpath, kwargs = self.serialize()
return self.repr(classpath, kwargs)
+ def __eq__(self, other: Any) -> bool:
+ if not isinstance(other, BaseTrigger):
+ return False
Review Comment:
```suggestion
if not isinstance(other, BaseTrigger):
return NotImplemented
```
It gives the `other` a chance to have it's `__eq__` method called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
