potiuk commented on PR #45630: URL: https://github.com/apache/airflow/pull/45630#issuecomment-2595443755
> The fact that we didn't catch this when create_event was removed from the hook means that something is not working properly with the tests. Merging to unblock the notifier but would be cool if someone has the time to look into the tests .They were just mocking hook's methods not API methods. But the fact is that MyPy should detect it. For some reason it did not. The "self.hook" is clearly `PagerdutyEventsHook` and it does not have `create_event` so there should be `no attr_defined` or similar mypy error ... but you never know with MyPy. Sometimes it does not detect obvious things like that. Potentially we could mock `pdpyras.EventsAPISession(self.integration_key)` session usage rather than hook usage and it would be detected in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
