jscheffl commented on code in PR #45678:
URL: https://github.com/apache/airflow/pull/45678#discussion_r1919098582
##########
newsfragments/41758.significant.rst:
##########
@@ -10,3 +10,28 @@ Removed deprecated functions and modules from
``airflow.www`` module.
``airflow.utils.log.secrets_masker.get_sensitive_variables_fields`` instead.
- Removed the method ``should_hide_value_for_key()`` from
``airflow.www.utils``: Please use
``airflow.utils.log.secrets_masker.should_hide_value_for_key`` instead.
+
+* Types of change
+
+ * [ ] DAG changes
+ * [x] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency change
+ * [ ] Code interface change
Review Comment:
I would say due to deprecations if people use it in private code it is a
non-public API cleanup.
```suggestion
* [x] Code interface change
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
