vincbeck opened a new pull request, #45765:
URL: https://github.com/apache/airflow/pull/45765
The plan to support FAB auth manager in Airflow 3 is:
- Create a trimmed version of the Airflow 2 Flask application in FAB
provider. This is done ✅
- Embed this Flask application in fastapi application using `WSGIMiddleware`
when FAB auth manager is the auth manager configured in the Airflow
environment. This is done ✅
- Update the FAB provider Flask application login process to be compatible
with Airflow 3 UI. This is this PR
- Update `get_url_login` method in FAB auth manager to return the
appropriate login URL so that the fastapi application can retrieve this value
and pass it to the front-end. On the front-end, if the user is not
authenticated, it will redirect the user to this URL. It will be done in a
future PR.
### Testing
You can test this PR by going to `<endpoint>/auth/login`and enter
credentials. If you get successfully authenticated you'll be redirected to
Airflow 3 UI with a JWT token.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
