jedcunningham commented on code in PR #44963:
URL: https://github.com/apache/airflow/pull/44963#discussion_r1924409618
##########
helm_tests/other/test_keda.py:
##########
@@ -58,6 +58,17 @@ def test_keda_enabled(self, executor, is_created):
@pytest.mark.parametrize(
"executor", ["CeleryExecutor", "CeleryKubernetesExecutor",
"CeleryExecutor,KubernetesExecutor"]
)
+ def test_include_event_source_container_name_in_scaled_object(self,
executor):
Review Comment:
Can you add a test for the triggerer
[here](https://github.com/apache/airflow/blob/dabb6635070466c51490257d6b706107b9c775d3/helm_tests/airflow_core/test_triggerer.py#L756)
as well?
##########
helm_tests/other/test_keda.py:
##########
@@ -58,6 +58,17 @@ def test_keda_enabled(self, executor, is_created):
@pytest.mark.parametrize(
"executor", ["CeleryExecutor", "CeleryKubernetesExecutor",
"CeleryExecutor,KubernetesExecutor"]
)
+ def test_include_event_source_container_name_in_scaled_object(self,
executor):
+ docs = render_chart(
+ values={
+ "workers": {"keda": {"enabled": True}, "persistence":
{"enabled": False}},
+ "executor": executor,
+ },
+ show_only=["templates/workers/worker-kedaautoscaler.yaml"],
+ )
+ assert jmespath.search("spec.scaleTargetRef.envSourceContainerName",
docs[0]) == "worker"
+
+ @pytest.mark.parametrize("executor", ["CeleryExecutor",
"CeleryKubernetesExecutor"])
Review Comment:
Can you update this parametrization? The list of executors was updated
recently :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
