eladkal commented on code in PR #45931:
URL: https://github.com/apache/airflow/pull/45931#discussion_r1925299794
##########
airflow/config_templates/config.yml:
##########
@@ -1296,6 +1296,15 @@ secrets:
sensitive: true
example: ~
default: ""
+ backends_order:
+ description: |
+ Comma-separated list of secret backends. These backends will be used
in the order they are specified.
+ Please note that the `environment_variable` and `metastore` are
required values and cannot be removed
+ from the list. Supported values are: `custom`, `environment_variable`,
`metastore`.
+ version_added: 2.10.5
+ type: string
+ example: ~
+ default: "custom,environment_variable,metastore"
Review Comment:
isn't this breaking change? What is custom? Is it for rolling secret backend?
The current order is not the same as you listed:
> If you enable an alternative secrets backend, it will be searched first,
followed by environment variables, then metastore. This search ordering is not
configurable.
Also you need to make doc changes to explain about this new functionality
https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#search-path
##########
airflow/config_templates/config.yml:
##########
@@ -1296,6 +1296,15 @@ secrets:
sensitive: true
example: ~
default: ""
+ backends_order:
+ description: |
+ Comma-separated list of secret backends. These backends will be used
in the order they are specified.
+ Please note that the `environment_variable` and `metastore` are
required values and cannot be removed
+ from the list. Supported values are: `custom`, `environment_variable`,
`metastore`.
+ version_added: 2.10.5
Review Comment:
This can not be in 2.10.5 nor in 2.11 it's a new feature. Will have to wait
for Airflow 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
