potiuk opened a new pull request, #45955:
URL: https://github.com/apache/airflow/pull/45955
While testing "standard" provider move to the new structure it turned out,
that "providers" package used now to keep tests in the new providers is
problematic - while it solves the ambiguity of "from celery import", it
introduces another ambiguity when trying to import internal utility classes in
tests. For example when trying to import BasePythonTest in standard operatori
currently we refer to the import from root directory of Airflow::
```
from providers.tests.standard.operators.test_python
```
However, if we change the package structure to have `providers` as
subpackage of `tests` and trying to import it from `tests` as root folder to
tests, we have:
```
from providers.standard.operators.test_python
```
And it can ambiguously attempt to import
```
from airflow.providers.standard.operators.test_python
```
This confuses IDEs and attempts to run multiple tests together, because
pytest modifies PYTHONPATH while running tests - and PYTHONPATH modification
can be different, depending on which tests are selected to run.
Changing the sub-package to provider_tests makes it unambiguous and we can
now import:
```
from provider_tests.standard.operators.test_python
```
This is unambiguous and allows to import the tests inside the provider
package, without importing from root of Airlfow package - making provider
package tests "standalone" inside provider.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
