eladkal commented on code in PR #45954:
URL: https://github.com/apache/airflow/pull/45954#discussion_r1927083623


##########
providers/src/airflow/providers/salesforce/hooks/salesforce.py:
##########
@@ -151,6 +151,7 @@ def conn(self) -> api.Salesforce:
             session=self.session,
             client_id=self._get_field(extras, "client_id") or None,
             consumer_key=self._get_field(extras, "consumer_key") or None,
+            consumer_secret=self._get_field(extras, "consumer_secret") or None,

Review Comment:
   You'll need also to update docs 
   
https://github.com/apache/airflow/blob/5c0e98cc770b4f055dbd1c0b60ccbd69f3166da7/docs/apache-airflow-providers-salesforce/connections/salesforce.rst#L46
   
   and `get_connection_form_widgets` function.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to