ashb commented on code in PR #45961:
URL: https://github.com/apache/airflow/pull/45961#discussion_r1929088059


##########
airflow/models/dagrun.py:
##########
@@ -1227,11 +1217,11 @@ def 
_emit_true_scheduling_delay_stats_for_finished_state(self, finished_tis: lis
         rid of the outliers on the stats side through dashboards tooling.
 
         Note that the stat will only be emitted for scheduler-triggered DAG 
runs
-        (i.e. when ``external_trigger`` is *False* and ``clear_number`` is 
equal to 0).
+        (i.e. when ``run_type`` is *MANUAL* and ``clear_number`` is equal to 
0).

Review Comment:
   I think we need to look at what the intent here was, and how that maps on to 
the new dag run types. My guess is that when "external_trigger" was added, 
there was either scheduled, or external.
   
   So Manual is clearly not scheduled, but what abouty Backfill runs? How 
should we treat those. And for that I delegate to @uranusjr and @dstandish 
*boing flip* 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to