hussein-awala commented on code in PR #46041:
URL: https://github.com/apache/airflow/pull/46041#discussion_r1929578245


##########
tests/api_connexion/endpoints/test_config_endpoint.py:
##########


Review Comment:
   There is something strange with `mock_as_dict`, I'll check later



##########
airflow/example_dags/example_dag_decorator.py:
##########


Review Comment:
   ```
         - id: check-no-providers-in-core-examples
           language: pygrep
           name: No providers imports in core example DAGs
           description: The core example DAGs have no dependencies other than 
standard provider or core Airflow
           entry: "^\\s*from airflow\\.providers.(?!standard.)"
           pass_filenames: true
           files: ^airflow/example_dags/.*\.py$
   ```
   What about pre-installed providers? if we really want to keep the rule as it 
is, then I will need to update the example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to