potiuk commented on code in PR #45962:
URL: https://github.com/apache/airflow/pull/45962#discussion_r1929768605


##########
task_sdk/pyproject.toml:
##########
@@ -27,10 +27,11 @@ dependencies = [
     "httpx>=0.27.0",
     "jinja2>=3.1.4",
     "methodtools>=0.4.7",
-    "msgspec>=0.18.6",
     "psutil>=6.1.0",
     "structlog>=24.4.0",
     "retryhttp>=1.2.0",
+    "orjson>=3.10.11",

Review Comment:
   Question:
   
   Why don't we switch to jiter instead? Jiter is also written in rust, and 
it's been spun-off from Pydantic and Pydantic as of version 2.5.0 uses jitter 
(rather than using it internally) 
   
   https://docs.pydantic.dev/latest/concepts/json/
   
   https://docs.rs/jiter/latest/jiter/
   
   It also implements things like partial json parsing (i.e. json streaming) 
that makes things faster  and take less resources when large JSON files are 
involved.
   
   Has this been considered and checked? I'd hate to add another dependency 
when we could potentially use one that we already essentially have.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to