vatsrahul1001 commented on PR #45609: URL: https://github.com/apache/airflow/pull/45609#issuecomment-2615655180
> Looking for `public/connections` and `public/variables` is a good idea. > > In the current form it will not work because you remove `/` and replace them with `.` in the event name generation. > > I think we need to look for `public.connections` and `public.variables` **in** `event_name` (event_name contains `public.connections` or `public.variables`. Can you write a test to verify that the appropriate code is being called for connections and variables ? (You can provide a test dependency for`request` to give the appropriate route and mock `_mask_variable_fields` to verify that it's actually being called). @pierrejeambrun I have added a test. Also I am keeping event name with `/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
