jedcunningham commented on code in PR #46003:
URL: https://github.com/apache/airflow/pull/46003#discussion_r1930689746
##########
tests/charts/log_groomer.py:
##########
@@ -90,6 +90,28 @@ def test_log_groomer_collector_default_retention_days(self):
)
assert
jmespath.search("spec.template.spec.containers[1].env[0].value", docs[0]) ==
"15"
+ def test_log_groomer_collector_custom_env(self):
+ env = [
+ {"name": "WORKER_RELEASE_NAME", "value": "{{ .Release.Name
}}-workers"},
+ {"name": "AIRFLOW__LOG_RETENTION_DAYS", "value": "5"},
Review Comment:
Let's use a different env var, or drop this one altogether (that'd be my
vote) - it's exposed by the values file already and tested in
`test_log_groomer_retention_days_overrides`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
