potiuk commented on code in PR #46274: URL: https://github.com/apache/airflow/pull/46274#discussion_r1934943514
########## providers/standard/tests/provider_tests/standard/operators/test_generic_transfer.py: ########## @@ -26,6 +26,7 @@ from airflow.exceptions import AirflowProviderDeprecationWarning from airflow.models.dag import DAG +from airflow.providers.mysql.hooks.mysql import MySqlHook Review Comment: No. * It's ok to have dependency to other providers. src/ of each provider is on the path and you can import `from airflowproviders.OTHER_PROVIDER` - this is the same as if you have other providers installed from a package. * It's NOT ok to have `from providers.tests.OTHER_PROVIDER` - > this is test code for the other provider, it's not supposed to be imported from outside of this provider tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
