stefankeidel commented on code in PR #46237:
URL: https://github.com/apache/airflow/pull/46237#discussion_r1935144920


##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -214,6 +214,10 @@ spec:
           {{- if .Values.dagProcessor.logGroomerSidecar.retentionDays }}
             - name: AIRFLOW__LOG_RETENTION_DAYS
               value: "{{ .Values.dagProcessor.logGroomerSidecar.retentionDays 
}}"
+          {{- end }}
+          {{- if .Values.workers.logGroomerSidecar.frequencyMinutes }}

Review Comment:
   Yes, indeed, thanks! The unit tests had actually caught that, it was just 
not that easy to see from the test output. Managed to get a local setup up that 
lets me run the tests. Should be fixed now, I hope?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to