logarithm commented on PR #45864: URL: https://github.com/apache/airflow/pull/45864#issuecomment-2626028063
@potiuk - I looked at the code and how it can be unit-tested, and this is more challenging than I thought at first. Inside the `start_spark_job` it calls `create_namespaced_custom_object` from the `custom_obj_api`, which makes a call to kubernetes API and returns the response object (simple dictionary). The best option to implement the unit test was to mock the response of the `custom_object_api.create_namespaced_custom_object`. @potiuk - please let me know if this is what would be a good enough test or if you have any other options in mind. Thank you for your review in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
