davlum commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#discussion_r331533436
########## File path: airflow/executors/kubernetes_executor.py ########## @@ -45,199 +47,6 @@ MAX_LABEL_LEN = 63 -class KubeConfig: # pylint: disable=too-many-instance-attributes Review comment: The issue with `KubeConfig` existing in the `kubernetes_executor` module is that `WorkerConfiguration` takes `KubeConfig` as an argument. In order to get better linting, [I annotated that argument](https://github.com/apache/airflow/blob/9d0d3e3039aa37766003b639b11605a5675e4746/airflow/kubernetes/worker_configuration.py#L45), however this creates a circular dependency. `kubernetes_executor` module requires `WorkerConfiguration` and `WorkerConfiguration` requires `kubernetes_executor`. This refactor is also being done in #5256, but I feel as thought that PR had been a bit forgotten, and the conflicts might be a bit tedious at this point. I agree this change is unrelated and creates a lot of noise. I could quickly move this into another PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
