dstandish commented on code in PR #46390:
URL: https://github.com/apache/airflow/pull/46390#discussion_r1941670101
##########
airflow/api_fastapi/core_api/datamodels/dag_run.py:
##########
@@ -99,15 +100,11 @@ def check_data_intervals(cls, values):
@model_validator(mode="after")
def validate_dag_run_id(self):
if not self.dag_run_id:
- self.dag_run_id = DagRun.generate_run_id(DagRunType.MANUAL,
self.logical_date)
+ self.dag_run_id = DagRun.generate_run_id(
+ DagRunType.MANUAL, self.logical_date if self.logical_date is
not None else pendulum.now("UTC")
+ )
Review Comment:
on the [decision
doc](https://cwiki.apache.org/confluence/display/AIRFLOW/Option+2+clarification+doc+WIP),
question 6 states that when logical date is null, the run id should be
generated from run_after + random string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
