RNHTTR commented on code in PR #46257:
URL: https://github.com/apache/airflow/pull/46257#discussion_r1943317112
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -167,25 +167,25 @@ These can be useful if your code has extra knowledge
about its environment and w
.. _concepts:zombies:
-Zombie Tasks
-------------
+Task Heartbeat Timeout
+----------------------
No system runs perfectly, and task instances are expected to die once in a
while.
-*Zombie tasks* are ``TaskInstances`` stuck in a ``running`` state despite
their associated jobs being inactive
-(e.g. their process did not send a recent heartbeat as it got killed, or the
machine died). Airflow will find these
-periodically, clean them up, and either fail or retry the task depending on
its settings. Tasks can become zombies for
+``TaskInstances`` may get stuck in a ``running`` state despite their
associated jobs being inactive
+(for example, their local task job did not send a recent heartbeat as it got
killed, or the machine died). Such tasks were formerly known as zombie tasks.
Airflow will find these
Review Comment:
```suggestion
(for example if the ``TaskInstance``'s worker ran out of memory). Such tasks
were formerly known as zombie tasks. Airflow will find these
```
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -216,7 +216,7 @@ If you'd like to reproduce zombie tasks for
development/testing processes, follo
sleep_dag()
-Run the above DAG and wait for a while. You should see the task instance
becoming a zombie task and then being killed by the scheduler.
+Run the above DAG and wait for a while. You should see the task experiencing a
heartbeat timeout and then being killed by the scheduler.
Review Comment:
```suggestion
Run the above DAG and wait for a while. The ``TaskInstance`` will be marked
failed after <scheduler_zombie_task_threshold> seconds.
```
This should link to this doc:
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#scheduler-zombie-task-threshold
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -216,7 +216,7 @@ If you'd like to reproduce zombie tasks for
development/testing processes, follo
sleep_dag()
-Run the above DAG and wait for a while. You should see the task instance
becoming a zombie task and then being killed by the scheduler.
+Run the above DAG and wait for a while. You should see the task experiencing a
heartbeat timeout and then being killed by the scheduler.
Review Comment:
Honestly, the name of this config should change too.
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -167,25 +167,25 @@ These can be useful if your code has extra knowledge
about its environment and w
.. _concepts:zombies:
-Zombie Tasks
-------------
+Task Heartbeat Timeout
+----------------------
No system runs perfectly, and task instances are expected to die once in a
while.
-*Zombie tasks* are ``TaskInstances`` stuck in a ``running`` state despite
their associated jobs being inactive
-(e.g. their process did not send a recent heartbeat as it got killed, or the
machine died). Airflow will find these
-periodically, clean them up, and either fail or retry the task depending on
its settings. Tasks can become zombies for
+``TaskInstances`` may get stuck in a ``running`` state despite their
associated jobs being inactive
+(for example, their local task job did not send a recent heartbeat as it got
killed, or the machine died). Such tasks were formerly known as zombie tasks.
Airflow will find these
+periodically, clean them up, and either fail or retry the task depending on
its settings. The heartbeat of a local task job can timeout for
Review Comment:
```suggestion
periodically, clean them up, and mark the ``TaskInstance`` as failed or
retry it if it has available retries. The ``TaskInstance``'s heartbeat can
timeout for
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
