o-nikolas opened a new pull request, #46498:
URL: https://github.com/apache/airflow/pull/46498
Provider tests pass but there are many issues (after fixing a handful of
failures related to paths being used in tests which needed updating):
### 1) mypy failures:
Example:
```traceback
providers/amazon/src/airflow/providers/amazon/aws/operators/bedrock.py:358:
error:
Value of type "Optional[dict[str, Any]]" is not indexable [index]
if event["status"] != "success":
```
We have a helper `validate_execute_complete_event(event)` to check if the
event is None, for this exact reason. Which was working perfectly fine before
the migration but is now failing type checking locally for me on all operators.
### 2) docs
There are many _api docs which either seem out of date or have spelling
errors that seem to already be fixed. I do not know how to generate these docs.
I tried a docs build but that fails because all paths to system test examples
are now incorrect. I'm not sure if this is something unique to amazon, or if
the migration script failed (there were some issues related to the `aws`
directory within the `amazon` provider).
### 3) there are many bits of code that have not been static checked for
issues of spelling and words like "master". I've fixed most but some are in
places that are difficult to change.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
