bbovenzi commented on code in PR #46504:
URL: https://github.com/apache/airflow/pull/46504#discussion_r1946994490
##########
airflow/ui/src/pages/Dag/Overview/Overview.tsx:
##########
@@ -42,14 +44,19 @@ export const Overview = () => {
state: ["failed"],
});
- const { data: failedRuns, isLoading: isLoadingRuns } =
useDagRunServiceGetDagRuns({
+ const { data: failedRuns, isLoading: isLoadingFailedRuns } =
useDagRunServiceGetDagRuns({
dagId: dagId ?? "",
logicalDateGte: startDate,
logicalDateLte: endDate,
state: ["failed"],
});
- // TODO actually link to task instances list
+ const { data: runs, isLoading: isLoadingRuns } = useDagRunServiceGetDagRuns({
+ dagId: dagId ?? "",
+ limit: 14,
Review Comment:
Actually, I was doing some user testing here. I think we should use the
startDate and endDate variables from the TimeRange selectors in this query. As
a user, I would expect changing my time range to change the graph beneath it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
