jscheffl commented on PR #46591: URL: https://github.com/apache/airflow/pull/46591#issuecomment-2646606168
> > Seems the upper margin and the lower margin of each elements are not same, a bit weird, can we have it in sync? > > Good catch. I just checked the overall height and the label... but there seems to be a bit of un-aligned margin onthe filed in the right column... will update... Okay, fixed the layout glitch. I first thought it is a margin problem and then needed to hunt-down the root a bit. The problem was a condition that the helper text was _not_ conditionally be rendered but always also as an empty element. That space was causing an un-alignment. Therefore I needed to adjust the param spec interface as the description is provided by API as `null` and due to eslint all was assumed to be `undefined`. But it is not the same. Needed some `eslint-ignore` to correctly use and itnerpret a `null` value from description as this is always passed with null even if empty. Side effect is that the condition for markdown actually was broken, now the markdown is happyly and correctly displayed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
