ashb commented on code in PR #46613:
URL: https://github.com/apache/airflow/pull/46613#discussion_r1950782639
##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -754,6 +754,12 @@ def finalize(ti: RuntimeTaskInstance, state:
TerminalTIState, log: Logger):
)
# TODO: Run task failure callbacks here
+ # Pushing xcom for each operator extra links defined
+ for oe in ti.task.operator_extra_link_dict.values():
+ link, xcom_key = oe.get_link(operator=ti.task, ti_key=ti.id),
oe.xcom_key # type: ignore[arg-type]
+ log.debug("Setting xcom for operator extra link", link=link,
xcom_key=xcom_key)
+ _xcom_push(ti, key=xcom_key, value=link)
Review Comment:
Nit: lets move this to before the listeners (they _could_ timeout, and this
should be quick and happen before hand)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
