uranusjr commented on code in PR #46460:
URL: https://github.com/apache/airflow/pull/46460#discussion_r1952069881
##########
airflow/models/dag.py:
##########
@@ -928,21 +927,21 @@ def get_task_instances_before(
corresponding to any DagRunType. It can have less if there are
less than ``num`` scheduled DAG runs before ``base_date``.
"""
- logical_dates: list[Any] = session.execute(
- select(DagRun.logical_date)
+ run_after_cols: list[Any] = session.execute(
+ select(DagRun.run_after)
Review Comment:
Same, concepts like “before” and ”after” should still be defined by logical
date, so we shouldn’t change this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]