dstandish commented on code in PR #46554:
URL: https://github.com/apache/airflow/pull/46554#discussion_r1952670126
##########
tests/models/test_backfill.py:
##########
@@ -271,12 +266,12 @@ def _get_bdr(date):
# 2021-01-04 is "failed" so it may or may not be reprocessed depending
# on the configuration
- bdr = _get_bdr("2021-01-04")
Review Comment:
instead of changing the date, this should probably assert that exception
reason is None, and assert that the dag run assorciated with this bdr is the
same dag run that was created before the backfill. to document the behavior
that we are reusing dag runs and we don't regard it as any kind of exception in
that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
