amoghrajesh commented on PR #46681:
URL: https://github.com/apache/airflow/pull/46681#issuecomment-2655616740
> I'm a -0.25 on this one. Historically we've only done more than a single
line for things that land in the "Significant" block in the release notes.
Adding multiline for other sections would mean a different format for our
release notes, and until we have a new standard for that, it falls on the poor
release manager to sort out as they are building release notes.
>
> I'd say if there is something worth having more than a single line summary
about, it should be significant instead. The example you linked would be better
as significant, imo.
Thanks for the explanation!
I was under the impression that a significant change has to tick one of the
boxes under the template:
```
* Types of change
* [ ] Dag changes
* [ ] Config changes
* [ ] API changes
* [ ] CLI changes
* [ ] Behaviour changes
* [ ] Plugin changes
* [ ] Dependency changes
* [ ] Code interface changes
```
Doesn't seem to be the case with precommit. I think the change is
"significant" enough in that case. (One qn, maybe for @Lee-W - does a
significant newsfragments only cover "breaking" changes or is it OK to have a
significant change that is not a "breaking change"?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
