uranusjr commented on code in PR #46460:
URL: https://github.com/apache/airflow/pull/46460#discussion_r1953967113
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1486,7 +1465,12 @@ def _update_state(dag: DAG, dag_run: DagRun):
dag_run.state = DagRunState.RUNNING
dag_run.start_date = timezone.utcnow()
- if dag.timetable.periodic and not dag_run.external_trigger and
dag_run.clear_number < 1:
+ if (
+ dag.timetable.periodic
+ and dag_run.triggered_by != DagRunTriggeredByType.ASSET
+ and not dag_run.external_trigger
+ and dag_run.clear_number < 1
+ ):
Review Comment:
Hmm, OK. We also can’t get rid of `periodic` because e.g. `@once` would have
a scheduled run but that shouldn’t be counted as periodic. (OR… maybe we can
choose to change the behaviour in those cases? That’s a different discussion I
guess.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]