dabla commented on PR #45451: URL: https://github.com/apache/airflow/pull/45451#issuecomment-2656076429
> We better have the field as boolean rather than define it as json in extra. You can see Snowflake connection (`insecure_mode`)for reference > > https://github.com/apache/airflow/blob/7e9b9edd76a9535fd6137ab33142f2c735eb4d4b/providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py#L202 I've just checked the snowflake Hook, couldn't we do this change in another PR as this is quite a big change? Also I think we should think of some common code that could be reused across hooks, so I would prefer not to do this change in this PR but do it in another one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
