sunank200 commented on code in PR #46983:
URL: https://github.com/apache/airflow/pull/46983#discussion_r1966476458
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -256,7 +257,15 @@ def refresh(self) -> None:
with self.lock():
with self.hook.configure_hook_env():
self._fetch_bare_repo()
- self.repo.remotes.origin.pull()
+ self.repo.remotes.origin.fetch(
Review Comment:
Also, do we need to retry here?
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -256,7 +257,15 @@ def refresh(self) -> None:
with self.lock():
with self.hook.configure_hook_env():
self._fetch_bare_repo()
- self.repo.remotes.origin.pull()
+ self.repo.remotes.origin.fetch(
Review Comment:
nit: It appears you are handling two separate repositories (a bare repo and
a working copy); if I understand this right. It may help to add comments
explaining why both fetches are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
