kiran2706 commented on PR #46929: URL: https://github.com/apache/airflow/pull/46929#issuecomment-2677918186
> Let’s change the type annotation of `get_value` and `get_one` to remove None too. @uranusjr, The docstring explicitly states that passing None to key removes the filter and returns all XComs: "Pass None (default) to remove the filter." This clearly indicates that None is a valid and intentional use case. If we disallow None, we risk breaking scenarios where fetching all XComs without filtering by key is necessary. Since we rely on this behavior, we should ensure that None remains allowed, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
