bugraoz93 commented on code in PR #47073:
URL: https://github.com/apache/airflow/pull/47073#discussion_r1970309673
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -289,8 +315,12 @@ def _get_conn_params(self) -> dict[str, str | None]:
conn_config["client_id"] = conn.login
conn_config["client_secret"] = conn.password
conn_config.pop("login", None)
+ conn_config.pop("user", None)
conn_config.pop("password", None)
+ access_token = self.get_oauth_token(conn_config=conn_config)
+ conn_config["token"] = access_token
Review Comment:
```suggestion
conn_config["token"] =
self.get_oauth_token(conn_config=conn_config)
```
Not a blocker but a small nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
